fortran-lang / registry

Registry for Fortran package manager
MIT License
8 stars 3 forks source link

feat: show namespace maintainers and admins list in namespace page. #37

Closed arteevraina closed 1 year ago

arteevraina commented 1 year ago
arteevraina commented 1 year ago

Testable Link - https://registry-frontend-arteevraina.vercel.app/

minhqdao commented 1 year ago

I logged in some time ago and now I'm back on the webpage wanting to add add another namespace maintainer. However, adding another maintainer doesn't work (it says I'm "unauthorized") and even the logout doesn't work. Did the token expire? In that case I should be rerouted to the login page and not see my dashboard.

I'm using Safari btw.

Screenshot 2023-05-24 at 13 37 06
arteevraina commented 1 year ago
Screenshot 2023-05-24 at 13 37 06

Hi @minhqdao , Thanks for reporting this.

This is the testing url and there is high chance that your older cookies that were valid for the backend before it was reset. So, can you please clear the cookies for this testing url https://registry-frontend-arteevraina.vercel.app/ as well and see if it is still failing ?

minhqdao commented 1 year ago

Where can I see the changes made in this PR? I added a maintainer but I couldn't observe any UI changes on my dashboard.

minhqdao commented 1 year ago

Ok, I figured it out. I find it a bit complicated. Why adding extra buttons for every new feature? Just list all the maintainers in a vertical list here:

Screenshot 2023-05-24 at 13 47 24
minhqdao commented 1 year ago

Also the created date can't be correct. I created the namespace a while ago.

arteevraina commented 1 year ago

Also the created date can't be correct. I created the namespace a while ago.

Should be fixed now.

arteevraina commented 1 year ago

Where can I see the changes made in this PR? I added a maintainer but I couldn't observe any UI changes on my dashboard.

For package maintainers https://registry-frontend-arteevraina.vercel.app/packages/minhdao/version-f you can view package maintainers here.

minhqdao commented 1 year ago

Where can I see the changes made in this PR? I added a maintainer but I couldn't observe any UI changes on my dashboard.

For package maintainers https://registry-frontend-arteevraina.vercel.app/packages/minhdao/version-f you can view package maintainers here.

Where can I see it there? Can't find it.

minhqdao commented 1 year ago

Oh, using the button ...

However, sometimes the button appears, sometimes it doesn't. I've seen it once. But now, whatever I do, I can't make it reappear again.

minhqdao commented 1 year ago

Oh, I can reproduce it. When you go in via dashboard -> namespace -> package, you see the green button. If you don't follow that particular sequence, you never see the button. That shouldn't be.

It also means that you don't see it using this link:

For package maintainers https://registry-frontend-arteevraina.vercel.app/packages/minhdao/version-f you can view package maintainers here.

arteevraina commented 1 year ago

Hey @minhqdao ,

We discussed in the last meeting that show the button when the user is logged in. But, there is one issue with that, so every user that is logged in should be shown the button (for showing package maintainers) or only package maintainers or namespace admins or namespace maintainers ?

arteevraina commented 1 year ago

Hey @minhqdao ,

We discussed in the last meeting that show the button when the user is logged in. But, there is one issue with that, so every user that is logged in should be shown the button (for showing package maintainers) or only package maintainers or namespace admins or namespace maintainers ?

I would prefer only prefer admins, maintainers or package maintainers to be shown that button but maybe we can show it to every logged in user ?

minhqdao commented 1 year ago

Only show the button if the user is logged in and the user is a package maintainer, namespace maintainer or admin etc.

arteevraina commented 1 year ago

Only show the button if the user is logged in and the user is a package maintainer, namespace maintainer or admin etc.

@minhqdao You can verify it here.