fortran-lang / registry

Registry for Fortran package manager
MIT License
8 stars 3 forks source link

API for deleting package. #9

Closed arteevraina closed 1 year ago

arteevraina commented 1 year ago

I have created the PR for initializing the API for deleting a package. Though, I have not used the original API route that was discussed in #5 .

I had an idea to use this route.

/packages/<username>/<namespace_name>/<package_name>/delete 

instead of

/<username>/<package_id>/delete

because I was doubtful that _id of the mongo DB document would be correctly sent by the URL.

Commits to review:

@henilp105 @minhqdao @perazz @fortran-lang/fpm I have few questions here, Since we have nothing merged in the main branch as of today And this PR contains changes made by @henilp105 as well since the start of project. Should I consider creating this PR to the henils remote branch and can be reviewed there as of now because it will be easier to review then.

henilp105 commented 1 year ago

@arteevraina I had considered package_name in the field maybe it was incurred due to typo. I am considering package_name as the field in the API.

henilp105 commented 1 year ago

@arteevraina I had considered package_name in the field maybe it was incurred due to typo. I am considering package_name as the field in the API.

minhqdao commented 1 year ago

To answer your question: The ideal case would be that PRs are quickly merged into main and new PRs are also opened and merged against main. That and keeping PR sizes small should result in a small number of merge conflicts and short development cycles.

henilp105 commented 1 year ago

@arteevraina I have made the flask code modular which would make it easy to add new features/commits and also prevent (mostly) the merge conflicts.