include mkl libraries for intel on linux and MacOS

fortran-lang / setup-fortran

GitHub action to setup Fortran compiler and toolchain

https://github.com/marketplace/actions/setup-fortran

Apache License 2.0

75 stars 25 forks source link

include mkl libraries for intel on linux and MacOS #81

Closed iulusoy closed 2 months ago

iulusoy commented 7 months ago

mkl libraries included for most MacOS versions
mkl libraries included for all linux versions
new test for mkl installation
currently is not the default, the mkl test is run conditionally. With the inclusion of math libraries for more compilers+OS, the tests should run as default

wpbonelli commented 7 months ago

@iulusoy I rebased math from main, could you rebase this or enable contributions? I think we could merge soon and keep iterating

iulusoy commented 7 months ago

@iulusoy I rebased math from main, could you rebase this or enable contributions? I think we could merge soon and keep iterating

Did so and also added you to the repo.

wpbonelli commented 7 months ago

thanks @iulusoy I joined. in future you can just check this box to give a repo maintainer access to a PR branch from your fork without making them a full contributor

allow_edits

wpbonelli commented 5 months ago

@iulusoy can you revert the CSV changes and/or rebase? I updated math from main.

In general you can ignore the auto-update PRs on your fork (really they should just run on the main repo, I'll change that at some point) and just rebase from upstream instead.

wpbonelli commented 5 months ago

@iulusoy any idea on the test failures?

iulusoy commented 4 months ago

@iulusoy any idea on the test failures?

No, not really - I need to try this out in a container to see what is happening. Have it on my to-do list.

What about extending the math support to other compilers/windows? Should we assign responsibilities to move this forward? I will have some more time for this towards the end of next month, so I could look at gnu compiler; but I have no experience with installing them on windows and would like to pass that to someone who is more experienced with it.

wpbonelli commented 4 months ago

What about extending the math support to other compilers/windows? Should we assign responsibilities to move this forward? I will have some more time for this towards the end of next month, so I could look at gnu compiler; but I have no experience with installing them on windows and would like to pass that to someone who is more experienced with it.

I'm still not sure on the approach for other toolchains. Since BLAS/LAPACK were added to stdlib an alternative besides those mentioned in #55 could be an install_stdlib option, which could install the reference implementation, and install_mkl could be a one-off specific to the Intel toolchain.

This PR could be merged with mac/linux support and windows could come in a separate PR, then math could merge into main and we could release this as an Intel-specific feature.

Just thinking out loud

iulusoy commented 3 months ago

@iulusoy any idea on the test failures?

Seems that the apt installation of the mkl libraries changes the setvars script for mkl version 2021.1. Because of this I changed the order of the compiler vs mkl installation. The PR will be updated shortly.

iulusoy commented 2 months ago

@wpbonelli do you think this can be merged now, or do we need some more tests?

wpbonelli commented 2 months ago

@iulusoy do you mind doing a final rebase? looks like the diff still has changes in the compat scripts and CSVs.

iulusoy commented 2 months ago

@iulusoy do you mind doing a final rebase? looks like the diff still has changes in the compat scripts and CSVs.

Should be no more diffs to main now, other than the actual changes.

wpbonelli commented 2 months ago

Looks like this is still behind. Maybe helpful to squash everything down to your first commit e.g. git reset --soft 56f36a1, git commit --amend --no-edit before doing an interactive rebase so you only have to resolve conflicts once.