Active item doesn't toggle when collapse={false}

fortunar / react-sidemenu

React sidemenu component

57 stars 14 forks source link

Active item doesn't toggle when collapse={false} #3

Closed elgs closed 7 years ago

elgs commented 7 years ago

It seems when collapse={false}, the old active item doesn't become inactive when a new item is clicked.

fortunar commented 7 years ago

Exactly, that is desired effect of the property.

elgs commented 7 years ago

I think semantically collapse and toggle active item should be two different things. Do you think there's any chance to put them into separate options?

By the way, can you please leave this thread open for a while for further discussion? Thanks.