fortune13-ss13 / thewasteland

GNU Affero General Public License v3.0
9 stars 70 forks source link

(EXPLOIT FIX) Emotes no longer have runechat, AKA no more emotes above the head #714

Closed KillerGryphon closed 2 years ago

KillerGryphon commented 2 years ago

About The Pull Request

Runechats are cool for talking, and I love the feature, and normally it's fine to have runechat for emotes, buuuuuuuut it's now been ruined by people abusing it (see next section). This is just a simple toggle, so should this specific exploit be resolved another way, it can easily be switched back on.

Why It's Good For The Game

Current known exploit for this is smoke grenades. We operate a TDM server basically, so tactical things like smoke grenades are helpful normally, but with the runechat, someone can pop a smoke grenade, and run out of the smoke and be able to see the person still in the smoke coughing via runechat, and gun them down. You shouldn't be able to point out someone in smoke from coughing, ESPECIALLY from the outside, so this fixes that.

Pre-Merge Checklist

Changelog

xTrainx commented 2 years ago

This is a bit of a lazy approach that does more harm than what it fixes, not having to navigate the convulated mess that is the chat to interact with people is better than the ocasional power gamer using smoke names, and i would rather see those grenades gone before seeing emotes runechat turned off

ZAB909 commented 2 years ago

I like seeing emotes in runechat. Don't turn off emote runechat because of a few powergamers.

Kitsunemitsu commented 2 years ago

You are using a hammer to solve an issue you need a scalpel for. Think harder on a solution, dont just take the lowest common denominator solution that reads like its designed by a 3 year old.

KillerGryphon commented 2 years ago

This is a bit of a lazy approach that does more harm than what it fixes, not having to navigate the convulated mess that is the chat to interact with people is better than the ocasional power gamer using smoke names, and i would rather see those grenades gone before seeing emotes runechat turned off

You've survived before, you'll survive again. This is just turning off emotes, not all runechat. If you want to fix the exploit that way, be my guest.

I like seeing emotes in runechat. Don't turn off emote runechat because of a few powergamers.

Believe me, I like it too, but this is why we can't have nice things.

You are using a hammer to solve an issue you need a scalpel for. Think harder on a solution, dont just take the lowest common denominator solution that reads like its designed by a 3 year old.

I lack that knowledge to do that, but flipping a switch is far easier, and it sure does get people to notice the issue apparently.

xTrainx commented 2 years ago

It's not even an issue, it makes sense in-game to be able to hear someone coughting and aim at the smoke. If you don't want to be catched by this just wear a gas mask