search

fortune13-ss13 / thewasteland

GNU Affero General Public License v3.0
9 stars 70 forks source link

(EXPLOIT FIX) Smoke effects on mob changes #715

Closed KillerGryphon closed 2 years ago

KillerGryphon commented 2 years ago

About The Pull Request

Alternative to previous PR, removes coughing from smoke grenades, along with the dropping of all held items. If you wish to do these things, use tear gas grenades instead of regular smoke.

Why It's Good For The Game

Exploit with smoke grenades was found where using the grenade would allow someone outside the smoke to see the person inside the smoke perfectly due to runetext from the cough. Removes the dropping of all items in the smoke too, because if you're using a smoke grenade to escape you likely don't want to drop what's in your hands. If you want that effect, use tear gas grenades.

Pre-Merge Checklist

ogrigbe commented 2 years ago

sounds like a skill issue

KillerGryphon commented 2 years ago

The smoke grenade is meant to conceal, the cough makes it do the opposite of that.

Does it work well to kill people?: Yeah it works fucking amazing apparently. Makes my target blind, drop what they're holding, and make me able to see them when they can't see me? Fuckin' A I should be using this ALL THE TIME.

Is that a problem?: What is used in almost every other context (Real life, other games, etc.) is used inversely, to the detriment of the server, because it's not even a smoke grenade at all at that point, it's tear gas, which is another item.

Erdrom commented 2 years ago

It's smoke, it makes you cough. IC issue

KillerGryphon commented 2 years ago

It's smoke, it makes you cough. IC issue

Can't wait for the smoke and gas mask meta, so fun, so innovative. Surely this is the sign of a good server that fixes issues.

AndriiKatsubo commented 2 years ago

Just place the cough emote in random tile of cloud

KillerGryphon commented 2 years ago

Just place the cough emote in random tile of cloud

I encourage you to code that if you can.

BadAtThisGame302 commented 2 years ago

Do not merge this.

gilvian commented 2 years ago

"oh no you hear our *cough through smoke"

Wow its not like smoke is just smoke and not a magical place that deafens you for no reason

ghost commented 2 years ago
  1. not an exploit
  2. tear gas grenades arent common nor makeable (unless you're enclave or BOS)
  3. dropping is literally an intended affect
  4. if you're using smoke grenades wear a mask