fortytw0 / needfinder

Cheap and Fast - But is it better?
MIT License
1 stars 0 forks source link

Glove embedding class? #7

Closed AbeHandler closed 2 years ago

AbeHandler commented 2 years ago

I would like to run src.main with Glove or Mittens embeddings. Can we make a class for Glove that is analogous to the Word2Vec class? That way we can easily swap out the embedding type and compare across embeddings?

For instance, in src.main I would like to do the following:

    embedding =GloveEmbedding(corpus, config["wordvector_path"])
    ab = AroraBeam(embedding, corpus, config["community"], 
                  config["embedding_dimension"])
    sim = ab.rank(quotes)

DJ, if there is a better way to do this let me know. But this seems pretty natural based on the way you have laid out the code.

AbeHandler commented 2 years ago

fixed