Closed cssgirl closed 3 months ago
@cssgirl Something I'm noticing - npm run rename
doesn't seem to work. I don't think this was caused by your changes - it's not working in the base branch either. Seems like the dependencies aren't getting installed. Can you look into that?
Maybe we just need to add the dependencies to package.json manually?
const inquirer = require('inquirer');
const path = require('path');
const fsPromises = require('fs/promises');
@cssgirl Thank you! Would you mind dropping some testing AC in here so we can stress test the changes? Just any editorial expectations that you think might have been effected that we can verify.
@tropicandid @jackmakesthings - I've added some preliminary AC above!
I am updating the readme and have one small batch of changes (color variable names) - otherwise this should be ready to pull down and test!
Will we update the gesso version number once this is merged?
Last item I am working on - fixing the theme's rename functionality.
@cssgirl Something I'm noticing -
npm run rename
doesn't seem to work.
@jackmakesthings Fixed! Looks like it never actually worked. Seems like it was a copy of the same rename functionality we have in the block library and some variable names & stuff and the inquirer package were overlooked. Should be working now!
One last set of changes to be made:
@cssgirl I am seeing two small things OOTB. I've attached screenshots.
Testing AC:
theme.json
theme.json
updates & additions