Create a modal component for Gesso

forumone / gesso

Gesso Drupal theme

66 stars 13 forks source link

Create a modal component for Gesso #683

Closed coreylafferty closed 1 week ago

tomealter commented 8 months ago

Going to use <dialog> now that it has better browser support. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog#examples

tomealter commented 8 months ago

AC:

Use <dialog> element and available methods
Close modal on escape press
If modal contains remote media (<iframe>), reset src on close
Focus first tabbable element on open
Trap focus inside modal while open
Close modal on overlay click (outside inner content)
Allow scrolling inside modal

Possible Options

Dark vs. light theme
Overlay: true/false

dcmouyard commented 8 months ago

Just saw that USWDS has implemented this: https://designsystem.digital.gov/components/modal/

ShawnJW commented 8 months ago

The USWDS modal is not working for me when logged into the admin area, but works correctly when logged out. Disabling core/misc/ajax.js temporarily makes the issue go away, not sure if it's a theme issue with Gesso, or a Drupal issue unfortunately.

tomealter commented 4 weeks ago

PR: https://github.com/forumone/gesso/pull/855