Closed dcmouyard closed 6 months ago
Update, Testing multi-value fields, it does insert a comma between values, which does mess things up if you are trying to say use fences to get a multi-value field to output as an <ol>
or <ul>
, so if you are going to do something like that, the suggestions might be to check out something like the field_delimiter module.
it does insert a comma between values, which does mess things up if you are trying to say use fences to get a multi-value field to output as an
<ol>
or<ul>
The comma separated field items is how our default template is set up, but we could easily switch it so that it doesn’t.
That change would definitely be something that current projects would have to be mindful of when updating to match the latest Gesso. It also makes the default field output look weird if the Field Delimiter module isn’t installed out of the box.
It’s also very easy to set the default field template to not output commas on specific projects, which would be helpful on projects that use the Fences module.
I’m leaning towards not updating core Gesso to remove the commas, but I could be convinced otherwise. Thoughts?
Sorry for the late reply. I'm inclined to not make assumptions on behalf of the user, but it looks like Corey whipped up an elegant solution.
Fixes #790.
This PR:
field--no-wrapper.html.twig
template to only add wrapper markup if logged in and there are contextual links.