forumone / gesso

Gesso Drupal theme
66 stars 13 forks source link

[ISSUE-793] Add hero paragraph template with inline media #847

Closed gbeezus closed 1 month ago

gbeezus commented 2 months ago

Resolves #793

dcmouyard commented 2 months ago

@gbeezus What’s the best way to get the new paragraph in https://github.com/forumone/drupal-project/pull/103 into my local environment?

gbeezus commented 2 months ago

Not sure I completely understand the question @dcmouyard . I imagine you want to test the changes as cleanly as possible. If you have your own version of drupal-project that you are running tests off of you could checkout out the branch with the changes ISSUE-97-hero-paragraph and then copy the module to your current local install.

Alternatively, we are keeping a separate demo branch (mind it does not have the latest version of gesso) but that may also be a good starting point. drupal-project-demo. What I've been doing is:

Maybe that's all a bit clunky but we can find ways to refine testing around all of this.

Let me know if there is anything I can clarify

kmonahan commented 2 months ago

@dcmouyard Definitely no objection to you doing that work. I think you should branch off this work though and open a separate PR with your changes (either onto this branch or onto 5.x-RC, depending on when this gets merged). Seems like that would be a little easier to review, since I don't think your planned work needs to block this PR being added to Gesso (unless you feel like it should?)