search

forumone / nextjs-project

Next.js project template
0 stars 0 forks source link

update hero components to match changes to vanilla Gesso - https://gi… #114

Closed coreylafferty closed 5 months ago

coreylafferty commented 6 months ago

…thub.com/forumone/gesso/pull/862

coreylafferty commented 6 months ago

@kmonahan I didn't change this, but is there a reason the two hero components need different variable names for the media? If not, ok to change them both to heroImage as part of this PR?

kmonahan commented 5 months ago

@coreylafferty I think Dan has or is changing the names in Gesso Drupal to match. I believe they are different here because they were different in Gesso Drupal, and they're different in Gesso Drupal because handwaves reasons. Agree with changing them both to heroImage.