forus-labs / forui

Forus Lab's Flutter UI library

https://forui.dev

Other

416 stars 18 forks source link

Added FButton.icon for a single icon button #138

Closed sommye-ctr closed 2 months ago

sommye-ctr commented 2 months ago

Describe the changes This adds a FButton.icon constructor which will be used to create buttons having a single icon as their content. Resolves #121

Checklist

[x] I have read the CONTRIBUTING.md.
[x] I have included the relevant unit/golden tests.
[x] I have included the relevant samples.
[x] I have updated the documentation accordingly.

Bartozo commented 2 months ago

Just tried the library today and my first thought was that it is missing basic components such as IconButton 😅 Glad to see that someone has already started working on this. Any chances to push this new component soon?

auto-maid[bot] commented 2 months ago

Documentation Preview

Latest Commit SHA	fe6d68238705b3a607bfb24f6811455c55bcde87
Preview URL	https://3ee06dbd.forui-docs-dev.pages.dev/docs

You're seeing this because the docs/samples were updated.

sommye-ctr commented 2 months ago

Did most of the changes as mentioned

Pante commented 2 months ago

I think you accidentally undid the changes in your merge commit. 😅

sommye-ctr commented 2 months ago

I think you accidentally undid the changes in your merge commit. 😅

Ugh! I must have set to auto merge in IDE. WTH is going on

sommye-ctr commented 2 months ago

It should be fine now ig

Pante commented 2 months ago

Seems like there was a bug with our workflows which built code on the base branch instead of the head. I've updated the actions accordingly.

Pante commented 2 months ago

LGTM! Thanks for the contribution.