search

forus-labs / forui

Forus Lab's Flutter UI library
https://forui.dev
Other
498 stars 25 forks source link

Method to ensure package widgets look and feel similar/"close enough" to ForUI #220

Open patternpaul opened 1 month ago

patternpaul commented 1 month ago

Is your feature request related to a problem? Please describe. Most widget packages seem to leverage the default material theme and widgets. This means that when I inject those packages into my application, the look at feel are drastically different than the rest of the application based on ForUI. A good example would be the firebase_ui_auth package.

The default out of the box look and feel based off the material theme. image With enough work of linking up the ForUI theme and overriding the default theme it gets closer and is in a "close enough" state to not be jarring to the user ( I'm still working on overriding the the input theme ). image

Here is the overrides I've completed to get close to something looking similar. I fully realize I've probably selected the wrong ForUI configs to map over. image

Describe the solution you'd like It would be nice if there was a mapper that would map my current ForUI theme and output a default Material ThemeData as a starting point.

Describe alternatives you've considered Working with the exposed theme configs for a given package. This has been typically terrible since it's very dependent on what they've exposed.

Or maybe there is a straight forward answer that I've totally missed. It's very possible!

Additional context Love the UI Kit! It's what I've been looking for! It's so good I was willing to go through hand bomb hell to map the themes.

Pante commented 1 month ago

Thanks for taking the time to provide a detailed issue!

I think that creating a Material theme mapping is an interesting idea. However, I have a few concerns.

Firstly, I don't think that the mapping between Forui's theme and Material is going to be 1-1. There's going to be places where we need make trade-offs. I'm concerned whether if it's even possible to come up with a mapping that is consistent and looks good enough across several widgets/packages, or if we'll end up with something in uncanny valley.

Secondly, it is possible to share a list of packages that uses Material themeing? Most packages that I've personally used have their own theme-ing/styling configuration that doesn't integrate directly with Material's theming. Depending on those packages, it might make sense to provide those widgets directly instead. In your case, I could definitely see us providing some form of login page that integrates Firebase in the future.