forus-labs / forui

Forus Lab's Flutter UI library

https://forui.dev

Other

507 stars 25 forks source link

Make tile groups scrollable #284

Open Pante opened 4 days ago

Pante commented 4 days ago

Describe the changes This PR makes the following scrollable:

FTileGroup
FSelectTileGroup
FSelectMenuTile
FPopverMenu

Checklist

[x] I have read the CONTRIBUTING.md.
[x] I have included the relevant unit/golden tests.
[x] I have included the relevant samples.
[x] I have updated the documentation accordingly.
[x] I have updated the CHANGELOG.md if necessary.

auto-maid[bot] commented 4 days ago

Documentation Preview

Latest Commit SHA	908e4f1f9bde19ed45cafda4f96c3449c2104bf0
Preview URL	https://16da55bd.forui-docs-dev.pages.dev/docs

You're seeing this because the docs/samples were updated.

Pante commented 3 days ago

On a side note, we definitely need to do something about the large diffs in golden tests. It's kinda pointless having golden tests if everything regenerates. In this case, we would want to see that the widgets look similar for existing tests + help the reviewer identify new test results to verify the output.

That's fair. I think going forward, I'll try to minimize the amount of test cases I regenerate.

creeponsky commented 2 days ago

Is this pull request to solve this？ 🤔 618aaf85-4cbb-4553-afb2-d4029e3c3db4

Pante commented 2 days ago

Is this pull request to solve this？ 🤔

Yes, it was an oversight.