Upgrade to AWS's v2 SDK.

forward3d / cap-ec2

Capify-EC2 rewritten for Capistrano v3

MIT License

181 stars 118 forks source link

Upgrade to AWS's v2 SDK. #61

Closed kylev closed 7 years ago

kylev commented 8 years ago

A lot of structure has changed, so a lot if this is just updating how we iterate over things. Notable elements include:

Tags are now an array of key/value Hashes rather than a key value hash itself.
Instance lists come inside reservation groups.

Also, the EC2 client no longer defaults to looking at every region by default. You have to tell it a region for its query endpoint, forcing me to make :ec2_region required.

kylev commented 8 years ago

Any thoughts on this? I'd like to start seeing aws-sdk-v1 start disappearing from my dependency trees, and this is the last item in my toolbox that uses it.

tlrdstd commented 8 years ago

This would be great to have -- I agree with @kylev that this is the last gem forcing aws-sdk-v1 into my dependency tree. We've already monkey-patched the v1 usages out of cap-ec2, but it would be great to have it in the official gem.

okuramasafumi commented 7 years ago

I'd really appreciate if this PR gets merged because aws-sdk-v1 depends on old json gem, which cannot be installed with Ruby 2.4.0.

frandieguez commented 7 years ago

Any news on this? I'll looking forward to get this working

AlexMorreale commented 7 years ago

Definitely would love this merged.

minsikzzang commented 7 years ago

Looks good :+1: