search

forward3d / rbhive

Ruby gem for querying Apache Hive
http://www.forward3d.com
MIT License
98 stars 74 forks source link

Moved thin as a development dependency #14

Closed talbright closed 10 years ago

talbright commented 10 years ago

This should be a development dependency, as its not needed at runtime. In cases where someone is using Jruby they also may not be able to install or use rbhive.

Installing thin (1.5.1) Gem::Installer::ExtensionBuildError: ERROR: Failed to build gem native extension.

    /Users/trentalbrigh/.rvm/rubies/jruby-1.7.4/bin/jruby extconf.rb

NotImplementedError: C extension support is not enabled. Pass -Xcext.enabled=true to JRuby or set JRUBY_OPTS or modify .jrubyrc to enable.

(root) at /Users/trentalbrigh/.rvm/rubies/jruby-1.7.4/lib/ruby/shared/mkmf.rb:8 require at org/jruby/RubyKernel.java:1054 (root) at /Users/trentalbrigh/.rvm/rubies/jruby-1.7.4/lib/ruby/shared/rubygems/custom_require.rb:1 (root) at extconf.rb:1

andytinycat commented 10 years ago

Unfortunately, if you are using Thrift 0.9.1, Thin is required at runtime, so I can't merge this pull request.

What I've done is lock Thrift at 0.9.0, which doesn't have Thin as a runtime dependency. It's not great, but this is due to decisions made in the Thrift project.

talbright commented 10 years ago

Oh -- bummer. Out of curiosity, do you know what Thin is used for at runtime? It seems so strange when you think what Thrift is supposed to be about.

andytinycat commented 10 years ago

It's used in the Thrift::ThinHTTPServer class. It's really annoying because as soon as you include Thrift it'll pull in Thin, even though you aren't likely to be using this class. It was introduced in 0.9.1.

andytinycat commented 10 years ago

I've cut 0.5.2 with the version locked to Thrift 0.9.0 - should be good now, but let me know if you have any other problems.

talbright commented 10 years ago

Will do, thank you.