forward3d / rbhive

Ruby gem for querying Apache Hive
http://www.forward3d.com
MIT License
98 stars 74 forks source link

Generated namespaces for Thrift #52

Open pointlessone opened 5 years ago

pointlessone commented 5 years ago

There's a number of rather generically named classes in the generated Thrift files. There's a high chance of name collision between those classes and user code. The issue has been risen in a few issues an PRs: #20, #31, #49.

Solution is a bit non-trivial for a number of reasons. The main is that Thrift lib files are generated. The solution has to accommodate full regeneration of those files. It's unlikely that upstream would easily accept namespacing since not only Ruby files would be affected by the change. However, other languages might suffer from the same deficiency.

The proposed solution is to automatically namespace potentially colliding classes during gem packaging.

The obvious downside is that the collision issue is still present when the gem is installed from GitHub and not from the package.