ghost commented 7 years ago

Hi there,

I'm working on upgrading to v3, and have everything working except message attachments. Given an attachments array on the message object that looks something like:

[{
    filename: 'filename.png',
    path: 'absolute/path/to/filename.png',
    content: createReadStream('absolute/path/to/filename.png'),
    cid: 'EmbeddedImageCid'
}]

And a message object that looks something like:

const message = {
    from: 'me@example.com',
    to: 'you@example.com',
    subject: 'Email!',
    attachments
}

With the above, Email.send returns undefined. If I remove the message.attachments property, everything works great. Ahhhh, what am I missing?!

Update

If I manually call email.render and add my attachments to the message object after rendering, I can at least see that SOMETHING is happening.

const message = {
    from: 'me@example.com',
    to: 'you@example.com',
    subject: 'Email!'
}

message.html = await email.render(`${type}/html`, locals);
message.attachments = attachments;

return await email.send({
    message,
    locals
});

The above at least produces an acknowledgement that the attachment SHOULD have been sent. The preview contains this link. It sounds like the nodemailer author fixed this in version 4.1.1, but I'm running nodemailer@4.2.0.

Update 2

I've confirmed that the issue is not with the nodemailer package. Given the above configuration of the message object, transport.sendMail(message) works as expected (attachments attached). Neither previewMail(message) nor email.send(message, locals) produce the attachments.