search

forwardemail / email-templates

Create, preview (browser/iOS Simulator), and send custom email templates for Node.js. Made for @forwardemail, @ladjs, @cabinjs, @spamscanner, and @breejs.
https://forwardemail.net/docs/send-emails-with-node-js-javascript
MIT License
3.67k stars 337 forks source link

Doesn't re renders when locals changes #252

Closed sallomendo closed 7 years ago

sallomendo commented 7 years ago

I don't know if I'm the only one getting this bug, but once you send an initial email the subsequent emails don't get updated locals, so it renders the same as the initial.

I think it has to do with https://github.com/niftylettuce/email-templates/blob/master/index.js#L137

niftylettuce commented 7 years ago

I will have this fixed today. When I release a new version to NPM I will ping you. Also feel free to join our Slack at http://slack.crocodilejs.com/.

niftylettuce commented 7 years ago

Please install v3.0.9 from NPM. npm install email-templates@latest or yarn add email-templates@latest - this issue is fixed and tests have been written as well to ensure. Any further issues please open a new issue, and thanks again for reporting.

sallomendo commented 7 years ago

Awesome, thanks!