search

forwardemail / email-templates

Create, preview (browser/iOS Simulator), and send custom email templates for Node.js. Made for @forwardemail, @ladjs, @cabinjs, @spamscanner, and @breejs.
https://forwardemail.net/docs/send-emails-with-node-js-javascript
MIT License
3.67k stars 337 forks source link

move preview-email to devDependencies #258

Closed JimiHFord closed 6 years ago

JimiHFord commented 6 years ago

Correct me if I'm wrong, but shouldn't this be a devDependency?

codecov-io commented 6 years ago

Codecov Report

Merging #258 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #258   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files           1        1           
  Lines          88       88           
=======================================
  Hits           79       79           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 873590e...46a159f. Read the comment docs.

OmgImAlexis commented 6 years ago

This is like debug. It's required in all environments which means if it's missing in production an error will be thrown.