search

forwardemail / email-templates

Create, preview (browser/iOS Simulator), and send custom email templates for Node.js. Made for @forwardemail, @ladjs, @cabinjs, @spamscanner, and @breejs.
https://forwardemail.net/docs/send-emails-with-node-js-javascript
MIT License
3.67k stars 337 forks source link

Custom render function shouldn't look for templates on disk #290

Closed mjamado closed 6 years ago

mjamado commented 6 years ago

If a custom render function is passed in the config, renderAll was looking for templates on disk anyway, and if those were non-existent, it would fail to

This change avoids that lookup, and renders whatever the custom render function returns.

Closes issue #288.

codecov-io commented 6 years ago

Codecov Report

Merging #290 into master will increase coverage by 0.15%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   90.59%   90.75%   +0.15%     
==========================================
  Files           1        1              
  Lines         117      119       +2     
==========================================
+ Hits          106      108       +2     
  Misses         11       11
Impacted Files Coverage Δ
src/index.js 90.75% <100%> (+0.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a09c7c...98fe92b. Read the comment docs.

niftylettuce commented 6 years ago

Published as v3.6.0 to npm, thanks @mjamado.