search

forwardemail / email-templates

Create, preview (browser/iOS Simulator), and send custom email templates for Node.js. Made for @forwardemail, @ladjs, @cabinjs, @spamscanner, and @breejs.
https://forwardemail.net/docs/send-emails-with-node-js-javascript
MIT License
3.67k stars 337 forks source link

Allow to override message.from via send options #313

Closed peterpetre closed 6 years ago

peterpetre commented 6 years ago

Please allow to pass message.from on send options and this should override the this.config.message.from

niftylettuce commented 6 years ago

@peterpetre care to submit a pull request + test?

peterpetre commented 6 years ago

@niftylettuce https://github.com/niftylettuce/email-templates/pull/319 is ok?

niftylettuce commented 6 years ago

Since this would be a breaking change, I think I'll publish with major semver version, agreed?

niftylettuce commented 6 years ago

@peterpetre I have just merged your work. I updated the README and added a new section here https://github.com/niftylettuce/email-templates#v5-breaking-changes (might need a bit more explaining with an example - if you care to submit a PR to update this README with a code example that shows before/after issue that would be great). email-templates@5.0.0 has been published to NPM. Let me know if you have any issues, and thank you for your contributions to this project 👏 🎉