search

forwardemail / email-templates

Create, preview (browser/iOS Simulator), and send custom email templates for Node.js. Made for @forwardemail, @ladjs, @cabinjs, @spamscanner, and @breejs.
https://forwardemail.net/docs/send-emails-with-node-js-javascript
MIT License
3.66k stars 339 forks source link

consolidate.js dependency is not up to date on npm, cannot render twing. Fix here. #405

Closed ghost closed 4 years ago

ghost commented 4 years ago

Looks like consolidate.js hasn't been updated on npm for years, so lots of template engines are missing. To get the latest version .... 

npm install tj/consolidate.js#master
cd node_modules/email-templates
npm install tj/consolidate.js#master

I had to find a different template engine, I thought it was just me who instantly hated everything about pug! https://www.quora.com/Do-web-developers-use-tools-like-Jade-Pug-rather-than-code-in-raw-HTML/answer/Frank-M-Taylor-1 "I hate Jade/Pug with the passion of a thousand burning suns" - I know how he feels!

I love this email-templates package, but might I suggest anything but pug for newbies? If they want the sado-masochistic coding equivalent of nails on a blackboard, then offer pug as an option, but for newbies at least offer something friendly :)

niftylettuce commented 4 years ago

Also someone leaving a post on Quora, stating they have a certificate in programming and front-end development, and one from an online campus does not warrant it to be an expert opinion. I'm releasing a new version of email-templates with this bumped in just a moment.

shaunwarman commented 4 years ago

Out of curiosity is there a template engine you would prefer as an option? @digitaltoast

niftylettuce commented 4 years ago

v7.1.1 released to npm, thank you https://github.com/forwardemail/email-templates/releases/tag/v7.1.1

ghost commented 4 years ago

I just merged a few PR's and bumped consolidate to v0.16.0 @ https://github.com/tj/consolidate.js/releases/tag/v0.16.0.

@niftylettuce Wow - I just realised that you actually do ALL these projects! I feel bad for being critical now as you are ridiculously productive in open source; thank you so much for these releases.

But I still really struggle with Pug - so many syntactical tripwires and a steep learning curve. Whereas, with Twig (Twing), it's the same old standard html we all understand, with clearly defined {{tags}}. https://github.com/forwardemail/email-templates/issues/406 I really appreciate the work you've done to bring so many template engines on board which means whichever engine we prefer, we can use it. Thank you!