search

forwardemail / email-templates

Create, preview (browser/iOS Simulator), and send custom email templates for Node.js. Made for @forwardemail, @ladjs, @cabinjs, @spamscanner, and @breejs.
https://forwardemail.net/docs/send-emails-with-node-js-javascript
MIT License
3.66k stars 339 forks source link

Remove pify and @sindresorhus/is #409

Closed sibiraj-s closed 3 years ago

sibiraj-s commented 3 years ago
codecov-io commented 3 years ago

Codecov Report

Merging #409 (e30347c) into master (13409de) will decrease coverage by 0.08%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #409      +/-   ##
==========================================
- Coverage   89.23%   89.14%   -0.09%     
==========================================
  Files           1        1              
  Lines         130      129       -1     
==========================================
- Hits          116      115       -1     
  Misses         14       14
Impacted Files Coverage Δ
src/index.js 89.14% <100.00%> (-0.09%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13409de...e30347c. Read the comment docs.

sibiraj-s commented 3 years ago

@niftylettuce we can also remove @sindresorhus/is in favour of lodash. Should I make the change as well?

niftylettuce commented 3 years ago

go for it

sibiraj-s commented 3 years ago

done.

niftylettuce commented 3 years ago

v7.2.0 released

https://github.com/forwardemail/email-templates/releases/tag/v7.2.0

thank you so much for your contribution @sibiraj-s ❤️ 🙏 hope you are well

sibiraj-s commented 3 years ago

Thanks @niftylettuce for the quick response.

hope you are well

All good here. I hope you are doing good as well. 😄 🙏