search

forwardemail / email-templates

Create, preview (browser/iOS Simulator), and send custom email templates for Node.js. Made for @forwardemail, @ladjs, @cabinjs, @spamscanner, and @breejs.
https://forwardemail.net/docs/send-emails-with-node-js-javascript
MIT License
3.66k stars 339 forks source link

Breaking change in v8 #410

Closed ddolcimascolo closed 3 years ago

ddolcimascolo commented 3 years ago

Hi guys,

Our build fails when upgrading from v7.2.0 to v8.0.0 because of the bumped html-to-text dependency. The outputted text is slightly different, mostly in newlines. This is totally OK as you released a major version, but maybe it's worth mentionning that in the Breaking changes section of the README ?

Regards, David

niftylettuce commented 3 years ago

do you know what the default option is that we need to set to preserve existing usage and not break it?

ddolcimascolo commented 3 years ago

Sorry no 😔 I'm not even sure there's an option to set, maybe it's just the default behavior that was changed...

niftylettuce commented 3 years ago

what's the difference look like?

ddolcimascolo commented 3 years ago

AssertionError: expected 'Bonjour,\n\nUne nouvelle toolbox myToolbox a été créé par First Last\n\nCordialement,\n L\'équipe Stordata' to equal 'Bonjour,Une nouvelle toolbox myToolbox a été créé par First LastCordialement,\nL\'équipe Stordata'

+Bonjour,
+
+Une nouvelle toolbox myToolbox a été créé par First Last
+
+Cordialement,
+ L'équipe Stordata
-Bonjour,Une nouvelle toolbox myToolbox a été créé par First LastCordialement,
-L'équipe Stordata

The new version is actually far better, by the way. Closer to the rendered Html template.

niftylettuce commented 3 years ago

Oh that's awesome! Yeah definitely looks better at a glance. Maybe we just update the README? Can you submit a PR and show an example or something?

ddolcimascolo commented 3 years ago

Will do 👍

niftylettuce commented 3 years ago

Thank you!