forwardemail / email-templates

Create, preview (browser/iOS Simulator), and send custom email templates for Node.js. Made for @forwardemail, @ladjs, @cabinjs, @spamscanner, and @breejs.
https://forwardemail.net/docs/send-emails-with-node-js-javascript
MIT License
3.64k stars 339 forks source link

[fix] The juice step does not seem to be working #447

Closed smnbbrv closed 1 year ago

smnbbrv commented 1 year ago

Describe the bug

Node.js version:

18

OS version:

MacOS

Description:

The juice does not seem to be doing anything from v11 on. In version 10 it seems to be working as expected

Actual behavior

From version 11.0.0

image

Expected behavior

As it is in version 10.0.1:

image

I'm unsure whether the class attribute should be removed as well however I can live with that.

Code to reproduce

There is absolutely nothing unusual, just stepped through the documentation. The only change I've made was adding the CSS class

build/global.css

.red {
  color: red;
}

html.pug

html
  head
    link(rel="stylesheet", href="global.css", data-inline="data-inline")

  body
    p.red.blue Hi #{name},
    p Welcome to Mars, the red planet.

Checklist

titanism commented 1 year ago

https://github.com/forwardemail/email-templates/releases/tag/v11.0.0

https://github.com/forwardemail/email-templates#v1100