forwarder / belco-magento2

2 stars 9 forks source link

Fix dynamic properties #17

Open pepijnblom opened 5 months ago

pepijnblom commented 5 months ago

The module is currently breaking 2.4.6 with php 8.2 due to dynamic properties, here's a patch

Subject: [PATCH] fix dynamic properties of belco
---
Index: app/code/Belco/Widget/Helper/Data.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/app/code/Belco/Widget/Helper/Data.php b/app/code/Belco/Widget/Helper/Data.php
--- a/app/code/Belco/Widget/Helper/Data.php (revision 3c846603dbec5d956d2665105b2d29fb8b5126aa)
+++ b/app/code/Belco/Widget/Helper/Data.php (revision 6fc332298581c8065c5ce465ea7fb72a95355183)
@@ -8,6 +8,7 @@
 class Data extends \Magento\Framework\App\Helper\AbstractHelper
 {

+    public $logger;
     /**
      * @var \Belco\Widget\Model\Api
      */
Index: app/code/Belco/Widget/Model/Api.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/app/code/Belco/Widget/Model/Api.php b/app/code/Belco/Widget/Model/Api.php
--- a/app/code/Belco/Widget/Model/Api.php   (revision 3c846603dbec5d956d2665105b2d29fb8b5126aa)
+++ b/app/code/Belco/Widget/Model/Api.php   (revision 6fc332298581c8065c5ce465ea7fb72a95355183)
@@ -9,6 +9,7 @@
 class Api
 {

+    public $storeManager;
     /**
      * @var \Psr\Log\LoggerInterface
      */
DjangoZeelig commented 4 months ago

Thank you @pepijnblom,

Question for the Belco Developers:

Additionally, the current API implementation is breaking the checkout process, preventing customers from finalizing their payments. I am concerned about the stability of the current implementation and the patch, particularly its impact on critical functionalities like payment processing.

Thank you in advance,

henkvalk commented 3 months ago

@DjangoZeelig You can use falconmedia/magento2-belco-hyva

henkvalk commented 3 months ago

@DjangoZeelig

I added a PR for the Checkout error #19