search

forwarder / belco-magento2

1 stars 9 forks source link

PHP 8.1 compatibility #9

Closed peterjaap closed 2 years ago

peterjaap commented 2 years ago

We want to upgrade one of our clients' site to Magento 2.4.4 / PHP 8.1 but this extension isn't compatible with PHP 8.1, according to the composer.json.

However, the PHPCompatibility code sniffer says all is fine for PHP 8.1 so I guess it's just a question of updating the PHP constraint.

vendor/bin/phpcs -p belco-magento2 --standard=vendor/phpcompatibility/php-compatibility/PHPCompatibility --runtime-set testVersion 8.1
........... 11 / 11 (100%)

Time: 395ms; Memory: 12MB
peterjaap commented 2 years ago

Made a PR: https://github.com/forwarder/belco-magento2/pull/10

imichaelv commented 2 years ago

Thank you for submitting the PR,

I have accepted the #10 ticket,

Hopefully this would help with the upgrade.

If there is any questions, feel free to ask