search

forwards-long-jump / discotron

Modular Discord bot supporting plugins hosted on git repositories
MIT License
3 stars 5 forks source link

Use server acronym when no icon specified #24

Closed RedMser closed 4 years ago

RedMser commented 4 years ago

Closes #17

Uses canvas to generate an image which is used instead of the iconURL. Long acronym will scale to fit: image

Maybe the foreground and background color should not be hardcoded parameter values, but instead be retrieved from the respective css variables. But the model shouldn't know about rendering anyway, so it might make more sense to move this check over to each view? Just don't know how it should be de-duplicated then...

Blatoy commented 4 years ago

Maybe the background could've been set to transparent, or maybe you could've passed an element to it and use getComputedStyle, but this works well enough for me (we will just regret it if we decide to implement themes one day)