search

forwards-long-jump / discotron

Modular Discord bot supporting plugins hosted on git repositories
MIT License
3 stars 5 forks source link

Add installation script in javascript #53

Closed sowmiyamuthuraman closed 4 years ago

sowmiyamuthuraman commented 4 years ago

Fixes #48

RedMser commented 4 years ago

Can you please point me the issues?

I just pushed the fixes on your PR, you can see for yourself what I changed.

It was mainly the indentation and general code style was not in line with the project (although to be fair, we don't have any guidelines defined yet, so I can't blame you! :sweat_smile: )

I also took the opportunity to solve some issues that I couldn't get working inside of the shell script version.

sowmiyamuthuraman commented 4 years ago

Can you please point me the issues?

I just pushed the fixes on your PR, you can see for yourself what I changed.

It was mainly the indentation and general code style was not in line with the project (although to be fair, we don't have any guidelines defined yet, so I can't blame you! )

I also took the opportunity to solve some issues that I couldn't get working inside of the shell script version.

I didn't notice the commits. Thanks @RedMser