geomatsi
commented
2 years ago
- Move glibc patch into
package/glibc/xxx-whatever-snapshot-is-used.
I think it makes sense to keep patch in the board specific directory. No need to apply that patch for any glibc build since it is required only for rare ARC700 glibc build. That is going to minimize possible impact of glibc build failure due to any arc changes in the future.
Create a git-like .patch with the commit title, commit message & your SoB. In the commit message I'd put the following info:
- Origin of the patch: OpenWrt will do, especially if there's a reference to an earlier discussion - so that the future readers may figure out all the details of what is that and why it's done that way.
- A note on a fix you had to add for the dynamic linker symlink... and BTW it is worth adding that fix to the OpenWrt (where AFAIK we used to see a problem in run-time, so @EvgeniiDidin might be interested in that part).
- Why it won't be a part of the upstream glibc anytime soon (but pls be careful here to not put us in a silly situation). I'd say something like "Even though ARC700 port of the glibc is very-very similar to ARCv2 port, still as formally yet another ABI it requires proper maintenance in the upstream like running very extensive test-suite, be in charge of occasional failure fixes etc. And since ARCompact ISA is reaching its EOL it might not be very practical to invest so much work in something which may have use, but not that often - uClibc is much more used on ARC700. Still given the low-hanging fruit, let's make some people a bit happier and let them run those libs & apps which are not usable with uClibc".
Done. I split glibc patch into the following two patches:
- openwrt patch with ARC700 specific changes, adding references to the original ARCv2/ARC700 patch submitted to glibc mailing list
- patch adding specific loader name for ARC700
Also see the commit messages in those two patches.
- Get rid of the .props file and instead add all of those to the readme.txt in form of
nsimdrv -prop=xxx -prop=yyy ....The point is nobody cares about readme contents, while an extra file which is not generally super useful for the upstream project might raise some questions. Also while we're at it and refer to the nSIM, let's add some more visibility to that and point to where those interested in it might really obtain the tool: https://www.synopsys.com/cgi-bin/dwarcnsim/req1.cgi.
Done. Got rid of arc700.prop and added links to free nSIM version for Linux.
Regards, Sergey
abrodkin
Add ARC700 target for nSIM including support for both uClibc and glibc. Note that ARC700 target is not supported by glibc out of the box. Add out-of-tree patch to enable that support for testing and development purposes. By default build configuration snps_arc700_nsim_defconfig enables uClibc. Use menuconfig to switch to glibc.