search

foss42 / apidash

API Dash is a beautiful open-source cross-platform API Client built using Flutter which can help you easily create & customize your API requests, visually inspect responses and generate API integration code. It is supported for macOS, Windows, Linux, Android & iOS. A lightweight alternative to postman/insomnia.
https://apidash.dev
Apache License 2.0
1.66k stars 317 forks source link

fix: missing drag scrolling #300

Closed DenserMeerkat closed 7 months ago

DenserMeerkat commented 7 months ago

PR Description

Have used the data_table_2 and matched the current look

davi data_table_2
current_table data_table_2
Fixed the text obscuring issue current updated
current_formData new_form

Related Issues

Added/updated tests?

We encourage you to add relevant test cases.

DenserMeerkat commented 7 months ago

Setting the row height of the table constrained the text fields' heights and caused obscuring of the letters in existing fields. And by "varying height" if you mean why I have "1.6" at one place and "1.8" at the other its because the formdatafield has a suffix which affected the alignment.

So adding the height fixed it, but honestly, I don't know if its the right approach. image

animator commented 7 months ago

@DenserMeerkat Actually the suffix inside the textfield in formdata does not make sense. There should not be any nesting of widget inside the text field. It should actually be <name text field> = <text or file dropdown> <value text field>

Please make the necessary modifications.

DenserMeerkat commented 7 months ago

@DenserMeerkat Actually the suffix inside the textfield in formdata does not make sense. There should not be any nesting of widget inside the text field. It should actually be <name text field> = <text or file dropdown> <value text field>

Please make the necessary modifications.

sure, will change it right away.

animator commented 7 months ago

@DenserMeerkat as #313 is merged .. please refactor this PR to account for it.

DenserMeerkat commented 7 months ago

@DenserMeerkat as #313 is merged .. please refactor this PR to account for it.

Yeah, will do it right away.

animator commented 7 months ago

@DenserMeerkat sync this PR with the main branch and let me know when it is ready for review.

animator commented 7 months ago

@DenserMeerkat Your merge conflict resolution is incorrect. You have removed the changes that were made in the main branch today.

DenserMeerkat commented 7 months ago

Hey @animator I believe #350 is also solved with this PR without any code change. Scroll position & focus doesn't get reset with rebuilds.

DenserMeerkat commented 7 months ago

@DenserMeerkat Your merge conflict resolution is incorrect. You have removed the changes that were made in the main branch today.

Ohh will look into it now.

ashitaprasad commented 7 months ago

You can take a look at this commit where the changes were made - https://github.com/foss42/apidash/commit/0884a1405835ba3dc98000dfa7bec60b95a9e8b3

DenserMeerkat commented 7 months ago

Thanks @ashitaprasad I am going through it and replacing with the constants, but I'm not sure what to do about the cell padding changes.

DenserMeerkat commented 7 months ago

You have removed the changes that were made in the main branch today.

I apologize for the overlook, I assumed there were no new changes made in these files in the main branch.

I have added the constant labels, 'Add button' padding changes back, but I'm unsure what to do about the cell paddings, I believe I have matched the column paddings too.

animator commented 7 months ago

I just reviewed the conflict resolution. It looks fine. Regarding cell padding no changes were made from our end so you can now go ahead and do all testing and give any finishing touches before review.

DenserMeerkat commented 7 months ago

The PR is ready for review 👍.