Feat search requests - Githubissues

foss42 / apidash

API Dash is a beautiful open-source cross-platform API Client built using Flutter which can help you easily create & customize your API requests, visually inspect responses and generate API integration code. It is supported for macOS, Windows, Linux, Android & iOS. A lightweight alternative to postman/insomnia.

https://apidash.dev

Apache License 2.0

1.59k stars 301 forks source link

Feat search requests #330

Closed yashas-hm closed 6 months ago

yashas-hm commented 6 months ago

PR Description

This allows a user to search request based on name or url. When no request found an indicative text will be shown.

Fixed Renderflex issue in codegen language dropdown.

Related Issues

Related Issue #305
Resolves #305

Checklist

[x] I have gone through the contributing guide
[x] I have updated my branch and synced it with project main branch before making this PR
[x] I have run the tests (flutter test) and all tests are passing

Added/updated tests?

[x] No, and this is why: Wasn't sure which tests to include

https://github.com/foss42/apidash/assets/64674824/bec61355-cb22-439a-aae6-79cc27cd1fc2

yashas-hm commented 6 months ago

@ashitaprasad fixed the bug with last PR

animator commented 6 months ago

I would like you to spend some time on the problem and think it through. Do you even require any provider to solve this problem?

yashas-hm commented 6 months ago

I had implemented the search provider as a failsafe to show a circular loader when searching queries (loader UI change was not pushed with the commits somehow) in a big list or queries. I removed it now as I tested using 100 requests and there was no visible lagging in showing the filtered list.

animator commented 6 months ago

Review your code. The approach is still incorrect. This feature can be implemented at UI level without touching providers.

yashas-hm commented 6 months ago

I am manipulating only the request sequence provider to trigger UI change using a filter function in collection provider. Could you provide your thought for the filtering approach?

I can relocate the filter function outside the provider but manipulating the request sequence would be necessary to trigger the UI change.

animator commented 6 months ago

This feature has been implemented. Closing this PR.