Validated CodeGen for PHP (cURL) - Githubissues

foss42 / apidash

API Dash is a beautiful open-source cross-platform API Client built using Flutter which can help you easily create & customize your API requests, visually inspect responses and generate API integration code. It is supported for macOS, Windows, Linux, Android & iOS. A lightweight alternative to postman/insomnia.

https://apidash.dev

Apache License 2.0

1.56k stars 291 forks source link

Validated CodeGen for PHP (cURL) #377

Closed AcousticDeveloper closed 6 months ago

AcousticDeveloper commented 6 months ago

PR Description

This PR validates code generation for PHP cURL, adds tests and fixes bugs. Bugs fixed in this PR are -

Previously the generated code wasn't properly indented, hence this PR tries to fix the indentation.
HEREDOC notation for multi line string is changed to single quotes.
Multipart file support does not require utility classes. In this PR, CURLFILE class is used for handling files in formdata.

Related Issues

Related Issue #375
Closes #375

Checklist

[x] I have gone through the contributing guide
[x] I have updated my branch and synced it with project main branch before making this PR
[x] I have run the tests (flutter test) and all tests are passing

Added/updated tests?

[x] Yes

Local Setup for Testing

Install PHP following the instructions in the Documentation.
Locate php.ini file from locations mentioned in the configuration file location.
Locate extension=curl and uncomment to enable curl for php.
Create a file app.php and paste the generated code inside that file.
Execute the file using php ./app.php from the terminal.

animator commented 6 months ago

Why is there no closing tags for the php code ?>

AcousticDeveloper commented 6 months ago

Why is there no closing tags for the php code ?>

@animator PHP closing tag ?> in a file containing only PHP is optional. Refer to -

animator commented 6 months ago

Thanks for the PR.