Resolve issue #126 - Githubissues

foss42 / apidash

API Dash is a beautiful open-source cross-platform API Client built using Flutter which can help you easily create & customize your API requests, visually inspect responses and generate API integration code. A lightweight alternative to postman/insomnia.

https://apidash.dev

Apache License 2.0

1.37k stars 257 forks source link

Resolve issue #126 #424

Closed ketan-sonar closed 10 hours ago

ketan-sonar commented 2 weeks ago

PR Description

Added "+ Import" button beside "+ New" button.
The user can click on it to import a curl file to the app.

Video of the functionality

https://github.com/foss42/apidash/assets/62693272/2a5177bd-3ea0-4f00-b90e-7a429bcfe517

Related Issues

Related Issue #126
Closes #126

Checklist

[x] I have gone through the contributing guide
[x] I have updated my branch and synced it with project main branch before making this PR
[x] I have run the tests (flutter test) and all tests are passing

Added/updated tests?

Added tests for httpVerbFromString function and DragAndDropArea widget.

[x] Yes

ashitaprasad commented 2 weeks ago

The code is working, but there are some issues:

The import functionality is not extensible. It assumes that the input file is of type curl and has not been structured in such a way that it can support other formats
There is no separation between the UI layer and business logic (curl parsing and converting to request model). I recommend you to take a look at how code generation feature has been implemented.

ketan-sonar commented 2 weeks ago

Okay, I will do the suggested changes.

ketan-sonar commented 1 week ago

I have made the suggested changes. Please let me know if there is some issue.

ashitaprasad commented 10 hours ago

Thanks for taking this initiative @ketan-sonar 🎉

ketan-sonar commented 9 hours ago

Thank you! I'm glad I could contribute. Looking forward to more opportunities to collaborate and improve the project together.