search

fossar / selfoss

multipurpose rss reader, live stream, mashup, aggregation web application
https://selfoss.aditu.de
GNU General Public License v3.0
2.38k stars 345 forks source link

Feed icon replacing icon from different feeds #1189

Closed sonicnkt closed 4 years ago

sonicnkt commented 4 years ago

With the latest snapshot (selfoss-2.19-5661343.zip) i noticed that one feed that has an embedded feed logo (Gamestar.de) replaced the icon of other feeds as well. You can see this in the normal article list as well as the sources window.

I am not sure if this is related to the feed having an embedded logo but currently only that icon on my setup is "taking over" the other ones.

I mentioned this briefly in https://github.com/SSilence/selfoss/issues/1186 but since it still happens with the latest snapshot for me i opend a new issue.

I have modified fulltextrss.php like mentioned here https://github.com/SSilence/selfoss/issues/1114#issuecomment-511080224 to get thumbnails for all those feeds, but i cant image this being ralted to that.

Here are some screenshots of the issue: selfoss-icon-issue_1

selfoss-icon-issue_2

Before submitting this i noticed that a few minutes later another icon took over another feed:

selfoss-icon-issue_3

Anyone experiencing the same issue?

jtojnar commented 4 years ago

Thanks for reporting.

Bisection pointed to this change 87a63aae4e3001d576f34d3df1cae7896cde806f. Apparently, we created a new SpoutLoader for every spout we updated because it could only create a single instance of spout. The commit that broke things switched to creating a single SpoutLoader. It is nice how these refactors reveal broken assumptions from years ago.