search

fossar / selfoss

multipurpose rss reader, live stream, mashup, aggregation web application
https://selfoss.aditu.de
GNU General Public License v3.0
2.36k stars 343 forks source link

client: re-add styles to content #1221

Closed jtojnar closed 4 years ago

jtojnar commented 4 years ago

Reset.css removes all styling including from elements like <em> or <strong>. Let’s reapply it in entry contents.

I had to switch to SASS to be able to use scoped @import.

The unreset library contains stuff we do not need (semantic layout elements) but it is still nicer than writing it from scratch.

Alternately, we could switch to something like normalize.css and remove stuff we do not want (e.g. list styling for <ul> in the sidebar) ourselves but that is more work and I am not sure how much sense it makes for us. https://css-tricks.com/reboot-resets-reasoning/

Fixes: #1220

niol commented 4 years ago

I do not understand why we import some unreset stuff instead of styling em etc. elements like you suggested in the bug report.

jtojnar commented 4 years ago

The reset.css removes styling for all elements so we would need to add most of https://github.com/ixkaito/unreset.css/blob/master/_unreset.scss.