search

fossar / selfoss

multipurpose rss reader, live stream, mashup, aggregation web application
https://selfoss.aditu.de
GNU General Public License v3.0
2.36k stars 343 forks source link

Folders missing in the official zip file #1383

Closed fmunch closed 1 year ago

fmunch commented 1 year ago

Congrats on releasing 2.19!

While upgrading I noticed that the official zip file is missing some folders:

$ unzip -Z selfoss-2.19.zip | grep -E '^d' | sort         
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/data/cache/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/data/favicons/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/data/fulltextrss/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/data/logs/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/data/sqlite/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/data/thumbnails/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/src/controllers/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/src/controllers/Items/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/src/controllers/Opml/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/src/controllers/Sources/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/src/daos/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/src/daos/mysql/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/src/daos/pgsql/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/src/daos/sqlite/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/src/helpers/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/src/helpers/Storage/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/src/spouts/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/src/spouts/deviantart/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/src/spouts/facebook/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/src/spouts/github/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/src/spouts/reddit/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/src/spouts/rss/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/src/spouts/tumblr/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/src/spouts/twitter/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/src/spouts/youtube/
drwxrwxr-x  2.0 unx        0 b- defN 22-Oct-12 12:36 selfoss/vendor/bcosca/
...

The following folders are missing:

selfoss/
selfoss/data/
selfoss/public/
selfoss/src/
selfoss/vendor/
selfoss/vendor/bramus/router/.github/
selfoss/vendor/clue/stream-filter/.github/
selfoss/vendor/fossar/guzzle-transcoder/.github/
selfoss/vendor/fossar/transcoder/.github/
selfoss/vendor/guzzlehttp/psr7/.github/
selfoss/vendor/smalot/pdfparser/.github/

When extracting everything is created, but because of that Ansible's unarchive module does not apply the expected ownership, see ansible/ansible#35426.

Pretty minor issue though.

jtojnar commented 1 year ago

Weird, the .github directories should not be there at all.

I guess we also need to call https://github.com/fossar/selfoss/blob/fa3bace4da6010331b70f145dd0e3b43ef9713f1/utils/create-zipball.py#L70-L72 for root.