search

fossar / selfoss

multipurpose rss reader, live stream, mashup, aggregation web application
https://selfoss.aditu.de
GNU General Public License v3.0
2.35k stars 343 forks source link

Update to recent @floating-ui/react #1402

Open jtojnar opened 1 year ago

jtojnar commented 1 year ago

I tried updating @floating-ui/react-dom-interactions to 0.16.0 (now called @floating-ui/react):

https://github.com/fossar/selfoss/blob/b4d6cf9a1e236bf8c92f1a8957acbc1362e49288/assets/package.json#L4

Unfortunately, the changes between 0.12.0 and 0.13.0 (0.13.0 release notes) broke our tag colour chooser:

https://github.com/fossar/selfoss/blob/b4d6cf9a1e236bf8c92f1a8957acbc1362e49288/assets/js/templates/ColorChooser.jsx#L93-L118

Clicking the tag colour chooser button in the sidebar will cause the app to crash with Uncaught TypeError: this.button is null in react-aria-menubutton:

https://github.com/davidtheclark/react-aria-menubutton/blob/v7.0.3/src/createManager.js#L82

Either we are holding the libraries wrong, or the update revealed a bug in react-aria-menubutton. This will need to be investigated.