search

fossar / selfoss

multipurpose rss reader, live stream, mashup, aggregation web application
https://selfoss.aditu.de
GNU General Public License v3.0
2.36k stars 343 forks source link

Feed source URL is incorrectly encoded #1407

Closed baz4096 closed 1 year ago

baz4096 commented 1 year ago

In 2.19, URLs - using at least the type: "RSS Feed" - have incorrectly encoded characters.

image

For example:

This item (from a phpBB RSS feed) should link to https://stardot.org.uk/forums/viewtopic.php?t=26297&p=383328#p383328

but instead links to:

https://stardot.org.uk/forums/viewtopic.php?t=26297&p=383328#p383328

Note the incorrectly encoded ampersand entity: &

In this particular case, all items in a forum thread now can only open the first page.

Worked OK in 2.18.

jtojnar commented 1 year ago

Sorry about the delay, I wanted to fix it at the source but that would require breaking backwards compatibility of the API and I wanted to implement some other breaking changes at the same time.

In order to move this forward, I pushed a workaround for now. It is available in the latest development build https://github.com/fossar/selfoss#download

There are some other places where the double escaping occurs but those should not break the functionality at least.