feat(docker): add basic docker support

desaintmartin commented 1 year ago

Here is a first try of https://github.com/fossar/selfoss/issues/1350 as a simpler alternative / first step than https://github.com/fossar/selfoss/pull/1170

Here are some notes:

Scope is much smaller than #1170: only having a production container image
It's a two-stages image, instead of the separated "composer" stage of #1170. ~~If you think this could easily be done, feel free to point me to the right direction, but I was not able to properly separate build from serve (due to always needing to build extensions...)~~ edit: https://hub.docker.com/_/composer/ recommends doing what is done in this pr, so everything seems ok, and I now delete development packages.
cron in included within the container, which seems to be a very good compromise but may not be ideal in some rare situations
I'm assuming that SQLite is used and a data volume is mounted and config can be customized (mounted as volume). I haven't tried with external database.
It's not using fpm but ol' good apache. I'm assuming this is ok for now.

What do you think?

Potential next steps if this gets merged:

image building & hosting automation to GitHub Container Registry using Github Actions (I can do)
Kubernetes compatibility through Helm Chart with dedicated database (I can do)
dev-container
profit and glory

netlify[bot] commented 1 year ago

Deploy Preview for selfoss canceled.

Name	Link
Latest commit	29108917d22da78b87290d34b0ff2e6bd056da6b
Latest deploy log	https://app.netlify.com/sites/selfoss/deploys/65441d7039c136000849f091

desaintmartin commented 8 months ago

A few months later, let me try to answer.

Still the main obstacle is that I do not understand how users that want Docker expect to use the image so I have no way of evaluating whether the PR fits that.

I understand this issue. Maybe I can just say that I'm a Kubernetes contributor (see my profile) and my production clusters manage ~15000 running containers right now, if that helps. Of course I don't want to pretend to be someone here! ;)

Do people just run docker commands manually? Or use something like docker-compose? How do they handle updates? What are security considerations? How do people configure software? How do they manage data backups?

It really depend, some use docker-compose, some use raw docker/containerd commands, some use Kubernetes either directly or through Helm, some use home NAS like synology to manage containers for them, but all of them use container image definition.

I'm going to update a bit the PR to be more up-to-date and take into account your suggestions!

desaintmartin commented 8 months ago

Notes:

I haven't included a docker healthcheck. I am not sure it is always wanted. On kubernetes, healthcheck are a completely different system anyway
I disabled cron, so we still have to do it like today. Much more atomic / simpler like a container is supposed to be, much less surprise / bugs.
php:8.2-apache image, built on top of debian:12-slim, is 710MB (!!), final image is 770MB so 60MB more than upstream image, which is not bad, relatively speaking (absolutely speaking, this is huge, but this seems to be how it works today).
I now drop root, according to production good practices
We need minimalistic documentation, just tell me where you want it to be.
To build it: docker build --tag selfoss:docker-beta .
To run it: docker run --rm --name my-selfoss -p 80:80 -v data:/var/www/html/data selfoss:docker-beta

desaintmartin commented 4 months ago

Hello @jtojnar, would you have any time to review this PR?

fossar / selfoss