search

fossar / selfoss

multipurpose rss reader, live stream, mashup, aggregation web application
https://selfoss.aditu.de
GNU General Public License v3.0
2.35k stars 343 forks source link

client: Middle click on title to open entry in new tab #1471

Open PhrozenByte opened 7 months ago

PhrozenByte commented 7 months ago

Ten years after #452 (I'm feeling old...) it's time to try again to finally bring this tech-wise tiny but UX-wise major feature to upstream. I'm not aware of any good reason why one should be required to click on the tiny favicon to open an entry in a new tab.

I believe that this should be default behaviour. There's still the possibility to make this an opt-in feature using a new config.ini option, but I'd strongly discourage it - it's simple and basic, it doesn't affect other users, thus it shouldn't come with unnecessary complexity (like an option).

If you want to merge both #1470 and #1471, ignore this PR and merge #1472 instead. Merging any of the three PRs will automatically close the other two PRs.

Closes #1470 Closes #1472

netlify[bot] commented 7 months ago

Deploy Preview for selfoss canceled.

Name Link
Latest commit 845c8577c76680a65ed998ebf84d124a00dddb9a
Latest deploy log https://app.netlify.com/sites/selfoss/deploys/655fe4a778a42f00088b21ea
PhrozenByte commented 7 months ago

Related issue: #1411

jtojnar commented 7 months ago

I think this makes sense. Using a link might be a bit iffy from accessibility standpoint but then again, we used ARIA role=link before so this should not be a regression.

jtojnar commented 7 months ago

Actually, now I remember why we do not do this. Some spouts (e.g. Twitter) contain links in the title and links cannot be nested. I guess we can fall back to the old way when the title contains < character.