search

fossar / selfoss

multipurpose rss reader, live stream, mashup, aggregation web application
https://selfoss.aditu.de
GNU General Public License v3.0
2.36k stars 343 forks source link

Ability to hide Google/Twitter/facebook share button on mobile devices #196

Closed GLLM closed 11 years ago

GLLM commented 11 years ago

Via settings, it could be great to able to hide the Google+/Twitter/FaceBook/... buttons for those who do not use them !

I wish I could help & code :S

niol commented 11 years ago

Or even a way to disable those everywhere.

Weishaupt commented 11 years ago

I would appreciate a settings page in the front end for that though and not via configuration.ini

SSilence commented 11 years ago

Why disturbs you the share buttons? They are at the bottom of the page and not very big!

@Weishaupt: yes a frontend for the settings would be a nice thing.

GLLM commented 11 years ago

@ Tobias : because it uses screen estate on mobile devices, and if you don't use Twitter/FB/G+, it's wasted screen, or possible touch errors ! do you agree ?

The frontend settings is request #188 ;)

seanrand commented 11 years ago

Huh? I only see the share buttons when I scroll to the bottom of an item in mobile view, I don't see how they're wasting screen space...

GLLM commented 11 years ago

OK, if no one agrees, just leave it :)

SSilence commented 11 years ago

I also think that this are unnecessary options. I also use this share buttons very rarely, but they don't disturb me on the bottom of the page.

monreal commented 11 years ago

This is one thing that could be solved very well using user style sheets (as offered in https://github.com/SSilence/selfoss/pull/110). Selfoss would attach some ids or classes to those buttons and those of use who do not want them could just "display: none" them using CSS

GLLM commented 11 years ago

@monreal : true, even though an option is easier. unless a user.css overrides the normal css file. I've not dug uinto css customizations. Even if I'd really like to customize selfoss look.

monreal commented 11 years ago

@GLLM: to get rid of all share buttons you can now just add this to user.css: .entry-share { display: none; }

GLLM commented 11 years ago

@monreal Oh, you've just got my attention with this user.css !!

I have been modifying the css file to get something looking better (more modern/cleaner) with the on-the-fly CSS editor of Firefox, but it's a pain to manage when updating the sources on my server.

How does this user.css work, where is it supposed to be, any limitations ?

Thanks a lot buddy :) GLLM

monreal commented 11 years ago

How does this user.css work It's just an additional CSS file to add to or change the defaults.

where is it supposed to be You create it in the root of your selfoss installation, next to the config files

any limitations ?

  • it doesn't seem to like comments (/* .. */)
  • you need to remove those two files you also remove during upgrades and clear browser cache or force-reload
GLLM commented 11 years ago

OK, thank you very much @monreal ! Useful information :)

DO you know why all.css &all.js have to be removed ? Would be easier if it was not needed wouldn't it ?

GLLM

rontu85 commented 11 years ago

This two files are created by selfoss to only deliver one single js and css file to the user instead of several individual files. Internally selfoss checks if all.js/all.css exists. If not it will create them.

While your locally test your changes you could set DEBUG in the index.php to 1, 2 or 3, depending on how much information you want to get from selfoss. If DEBUG is not 0 selfoss will also recreate all.js and all.css. In a production environment you should always set DEBUG to 0 so don't forget to set it back.