fossar / selfoss

multipurpose rss reader, live stream, mashup, aggregation web application
https://selfoss.aditu.de
GNU General Public License v3.0
2.38k stars 345 forks source link

Remember last item from all feeds #230

Closed monreal closed 11 years ago

monreal commented 11 years ago

Maybe I am wrong but to me it looks like this: if all items of a feed expire because of items_lifetime, they are added to the database again on the next fetch. This problem mainly occurs when setting items_lifetime to a very low value but even with the default value set this happens on low traffic feeds like [1]. I think this could be worked around by storing some ID of the last item even if this gets removed from the DB and comparing "new" items to this stored value.

[1] http://icculus.org/cgi-bin/finger/finger.pl?user=icculus&rss=1

SSilence commented 11 years ago

I can not follow your problem. During the fetching of new items selfoss checks whether an item is older than items_lifetime and will not fetch this article again. Your example seems not to be a valid Atom/RSS feed.

monreal commented 11 years ago

I linked to the wrong icculus feed, this is the one I use and the problem shows with it: http://www.icculus.org/news/news_icculus_org.rss Is the feed broken?

SSilence commented 11 years ago

Yes, this feed seems to be a RDF XML Format and not a valid RSS feed. In any case it looks strange.

monreal commented 11 years ago

I think I have seen the same with at least one other feed but right now I do not know which one... I will keep my eyes open

SSilence commented 11 years ago

Ok, feel free to report problems with other feeds.

monreal commented 11 years ago

The same problem also occurs with this feed: http://www.gameolith.com/news/latest-deals/feed/ Does it look strange as well?