fossar / selfoss

multipurpose rss reader, live stream, mashup, aggregation web application
https://selfoss.aditu.de
GNU General Public License v3.0
2.36k stars 343 forks source link

Swipe on mobile doesn't work #270

Closed xcorp closed 11 years ago

xcorp commented 11 years ago

I just tried to use the new swipe navigation on both my Nexus 7(Firefox) and my Nokia N9(Built-in Browser), but none of them worked.

xcorp commented 11 years ago

Doesn't work with Chrome on Nexus 7 either.

SSilence commented 11 years ago

You are right, it doesn't work on Chrome. On my HTC One X it works on Firefox, Dolphine and the Android Browser. Just Chrome doesn't work.

xcorp commented 11 years ago

Tried Dolphin and it works, Nexus 7 doesn't ship with "Android Browser" so can't try with that, I', using Firefox 20.0.1

seanrand commented 11 years ago

Maybe I'm swiping wrong, but it doesn't seem to work for me in Dolphin.

seanrand commented 11 years ago

Oops, I might have broken this myself with commit 4ecdfcd. Hangs head in shame

The pull request above may fix this issue, if it doesn't then the bug you guys are seeing is different from the one i saw. (The bug fixed by the pr is probably due to my Gingerbread/CM7 install shipping with an older Webkit version.)

GLLM commented 11 years ago

On native browser in CM10.1 : scrolling down the article often goes to the next article ... it's horrible ! Please help :)

bluenenschloss commented 11 years ago

Swiping works quite well on iOS6. Scrolling down sometimes goes to next feed inadvertently.

bsweeney commented 11 years ago

Swiping generally works well on iOS6, but the up/down swiping needs some serious work. If I scroll extremely slowly it's fine, but if I do a normal swipe-to-scroll Safari jumps to the next/previous item. The vertical swiping also feels backwards, if I swipe top-to-bottom I expect to see the previous item but I see the next. Finally, it doesn't work at all if the item is not scrollable. Makes me think maybe vertical swiping was unintentional.

I think vertical swiping needs to be disabled until further testing is done. Or just disabled completely, because left/right swiping makes more sense to me.

Also, after using the swipe feature when you go back to the list of items you are always at the top of the list rather than at the item you were last viewing.

SSilence commented 11 years ago

You are right. Scrolling inside items is no longer possible with this swipe events. There is no possibility to prevent swipe events on scrolling in items. There is also no possibility to set a sensivity for vertical scrolling for swipeLeft or swipeRight in the quojs framework. I removed the touched support.

bsweeney commented 11 years ago

That's too bad, because I do like the idea of swipe support. I hope another library can come to the rescue.

jicho commented 11 years ago

"Scrolling inside items is no longer possible with this swipe events." -> Strange, I'm not experiencing that with Safari on iOS :S

In case you want to try, I've created a branch to test another setup: https://github.com/jicho/selfoss/tree/swipe

With Safari and Dolphin, both work the same. I can scroll vertical without any problems on my iPod. Swipe from right to left gives me the next item in full "view". Left to right, goes back. The up / down (and v.v.) works without problems. I've noticed that the right to left swipe on Dolphin can trigger the "side menu" when you start to close to the screen side :)

bsweeney commented 11 years ago

@jicho you can test out my install, I haven't updated yet after removal of the swipe functionality. http://eclecticgeek.com/reader

The vertical swipe appears to depend on the length of the finger drag. If I do a short flick I get scrolling. If I do a longer touch-and-drag I get the next/previous item. Also, if you are at the bottom and drag up (or the top and drag down) the item doesn't switch no matter how long of a finger drag you use.

jicho commented 11 years ago

@bsweeney: I've tested all the swipe options you've wrote about with Safari, Dolphin and Chrome on iOS (iPod), but I can't mimic the strange behavior.

What I did found is that the top bar (with the close button) sometimes scrolls out of the window. That's kind of strange, but maybe it had something to do with the swipe plugin in combination with the scrollbar plugin (I've seen one in the project), but I'm not sure.

Also tested on Mercury, swipe left/right and right/left doesn't work there with the current swipe plugin.

bsweeney commented 11 years ago

@jicho ... that's odd. What version of iOS. What device? Maybe it's a problem with a particular configuration. I can test on another device later, but still having problems on my iPhone 4 + iOS 6.1.3

jicho commented 11 years ago

@bsweeney I'm using iOIS 6.1.3 with an iPod Touch 4 generation.