Closed JeffreyHuynh1 closed 4 months ago
I'd like to see a more thorough test plan, though. The test plan only tests with one project being added to the release group and does not test any of the failure cases. I.e. it would be good to test what happens if you try to create a release group while missing the
--project-branch
flag. It would also be good to specifically test with multiple projects being added.
There's a test to see if the release group exists before creating the release: https://github.com/fossas/fossa-cli/pull/1409/files#diff-a6883bdfe80cf7750f86281dce66c203f54d3086a7bce60cb2fe46fb7a5c4019R45
It seems like you're suggesting that we incorporate more tests at the parsing level when constructing the CreateRelease config. Would it be something similar to: https://github.com/fossas/fossa-cli/blob/master/test/App/Fossa/Config/ReleaseGroup/CreateSpec.hs
We should also test the delete command that was added in this PR
The delete command was added in prior a PR. We have tests for it here: https://github.com/fossas/fossa-cli/blob/master/test/App/Fossa/ReleaseGroup/DeleteSpec.hs
* Or are you suggesting a more detailed manual testing plan?
I was suggesting a more detailed manual testing plan. Sorry for the confusion :)
Overview
The CLI should offer a way to create release group release from the command line
Acceptance criteria
Testing plan
example .fossa.yml:
Create a release group release:
fossa release-group create-release --title example-title --release example-release-title --project-locator custom+1/git@github.com/example --project-revision 12345 --project-branch main
fossa release-group create-release -c /path/to/.fossa.yml/
Risks
Metrics
References
Checklist
docs/
.docs/README.ms
and gave consideration to how discoverable or not my documentation is.Changelog.md
. If this PR did not mark a release, I added my changes into an# Unreleased
section at the top..fossa.yml
orfossa-deps.{json.yml}
, I updateddocs/references/files/*.schema.json
AND I have updated example files used byfossa init
command. You may also need to update these if you have added/removed new dependency type (e.g.pip
) or analysis target type (e.g.poetry
).docs/references/subcommands/<subcommand>.md
.