csasarak
commented
4 months ago Did you test that themis works from it? It did in my testing but it's good to get another check. @spatten I'll incorporate your suggestions.
Closed csasarak closed 4 months ago
csasarak
commented
4 months ago Did you test that themis works from it? It did in my testing but it's good to get another check. @spatten I'll incorporate your suggestions.
spatten
commented
4 months ago Did you test that themis works from it? It did in my testing but it's good to get another check. @spatten I'll incorporate your suggestions.
I hadn't, but I just did and it works. Good call!
~/Downloads/macOS-arm64-binaries/fossa license-scan directresults in output from Themis
Overview
This adds an arm build of the CLI for Mac. You can get binaries from the
build macOS-aarch64-buildaction below.I will relax and replace some of the required checks for this branch before and after the merge to master.
Acceptance criteria
A build that works on Mac M1.
Testing plan
I set up an ARM EC2 instance, copied the binaries there and ran them. Additionally I ran a direct license-scan to verify that the license scan program worked correctly.
If you are on an ARM mac, downloading the binaries from the release step and running them should also test this.
I tested the install script to make sure that it correctly selects the arm build if it's fetching a valid version. Otherwise it falls back to the intel version of the CLI like before.
Currently, running the cli and just getting the latest fails with a 404, but the generated URL is what I expect it to be:
Risks
Costs will increase since we will be allocating two runners for Mac per build. Caching may become less reliable as we make more cache data as well.
Metrics
References
ANE-572
Checklist
docs/.docs/README.msand gave consideration to how discoverable or not my documentation is.Changelog.md. If this PR did not mark a release, I added my changes into an# Unreleasedsection at the top..fossa.ymlorfossa-deps.{json.yml}, I updateddocs/references/files/*.schema.jsonAND I have updated example files used byfossa initcommand. You may also need to update these if you have added/removed new dependency type (e.g.pip) or analysis target type (e.g.poetry).docs/references/subcommands/<subcommand>.md.