fossas / fossa-cli

Fast, portable and reliable dependency analysis for any codebase. Supports license & vulnerability scanning for large monoliths. Language-agnostic; integrates with 20+ build systems.
https://fossa.com
Other
1.26k stars 173 forks source link

Ane 1808 suppress reachability notice #1440

Closed csasarak closed 2 months ago

csasarak commented 2 months ago

Overview

Reachability analysis is quite noisy, and many customers don't have it enabled for their organization anyways. This PR changes it so that:

  1. Reachability analysis is skipped when the organization doesn't have reachability enabled. This means that "reachability not supported" messages as well as the entire reachability summary isn't printed out.
  2. For an organization that does have it enabled, the messages will be the same. These are noisy, but we can refine them a bit in the future.
  3. It still outputs a single message about reachability being turned off at the end of analysis regardless of whether reachability is enabled or not.
  4. It will still try to do analysis and print out the analysis log messages with the -o option. We have no way of knowing if reachability is enabled in that case so it defaults to doing it.

Acceptance criteria

The output isn't nearly as noisy.

Testing plan

I tested by analyzing projects while having reachability analysis enabled or disabled in my organization.

Risks

None.

Metrics

Is this change something that can or should be tracked? If so, can we do it today? And how? If its easy, do it

References

ANE-1808

Checklist