Fast, portable and reliable dependency analysis for any codebase. Supports license & vulnerability scanning for large monoliths. Language-agnostic; integrates with 20+ build systems.
curl errors are not surfaced to users.
Also, the install-latest script was configuring the wrong setting (HTTP_STATUS instead of http_status).
This PR fixes both issues.
Acceptance criteria
Error messages emitted by curl are no longer suppressed when installing FOSSA CLI.
The progress dialogue is still suppressed.
Testing plan
I configured my hosts file:
127.0.0.1 github.com
I validated that curl's error does not appear (other than the --write-out error, which is unrelated):
❯ sudo ./install-latest.sh
fossas/fossa-cli info checking GitHub for latest tag
curl: unknown --write-out variable: 'HTTP_CODE'
fossas/fossa-cli crit unable to find '' - use 'latest' or see https://github.com/fossas/fossa-cli/releases for details
Then I applied the changes in this PR and validated that the curl error does appear (note the curl: (7) text):
❯ sudo ./install-latest.sh
fossas/fossa-cli info checking GitHub for latest tag
curl: (7) Failed to connect to github.com port 443 after 2 ms: Could not connect to server
fossas/fossa-cli err http_download received HTTP status 000 from https://github.com/fossas/fossa-cli/releases/latest
fossas/fossa-cli crit unable to find '' - use 'latest' or see https://github.com/fossas/fossa-cli/releases for details
[x] I added tests for this PR's change (or explained in the PR description why tests don't make sense).
[x] If this PR introduced a user-visible change, I added documentation into docs/.
[x] If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
[x] If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an # Unreleased section at the top.
[x] If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
[x] If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.
Overview
curl errors are not surfaced to users. Also, the
install-latestscript was configuring the wrong setting (HTTP_STATUSinstead ofhttp_status).This PR fixes both issues.
Acceptance criteria
Testing plan
I configured my hosts file:
I validated that curl's error does not appear (other than the
--write-outerror, which is unrelated):Then I applied the changes in this PR and validated that the curl error does appear (note the
curl: (7)text):Risks
None
Metrics
None
References
https://fossa.atlassian.net/browse/ANE-1953
Checklist
docs/.docs/README.msand gave consideration to how discoverable or not my documentation is.Changelog.md. If this PR did not mark a release, I added my changes into an# Unreleasedsection at the top..fossa.ymlorfossa-deps.{json.yml}, I updateddocs/references/files/*.schema.jsonAND I have updated example files used byfossa initcommand. You may also need to update these if you have added/removed new dependency type (e.g.pip) or analysis target type (e.g.poetry).docs/references/subcommands/<subcommand>.md.